widelands-dev team mailing list archive

[kaputtnik <somal@xxxxxxxx>]

Review: Needs Fixing image_url

Ah, ok, i just looked in the tables in column "Stores" ... but this column meant only wares, not workers.

Some nits:
1. Please check for correct indentation (python prefers spaces for indentation). The file update_wlhelp.py has a mix of tabs and spaces. See also https://www.python.org/dev/peps/pep-0008/ You could just ran pyformat over the file(s)
2. The paths for images in the database contains three slashes after "/wlmedia", f.e.such a string is stored: 
"/wlmedia///wlhelp/img/empire/empire_sentry/menu.png"

If you use database sqlite you could check the contents with:
sqlite3 dev.db #runs sqlite database console and open dev.db as database
select displayname, image_url from wlhelp_building where tribe_id=2; #returns all rows with tribe_id=2 (2=empire, 1=barbarians, 3=atlanteans) and shows the content of columns "displayname" and "image_url" from table "wlhelp_building" 

You could use the second sql query also for mysql driven databases.
-- 
https://code.launchpad.net/~widelands-dev/widelands-website/encyclopedia/+merge/287410
Your team Widelands Developers is subscribed to branch lp:widelands-website.