← Back to team overview

widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/bug-1603763 into lp:widelands

To: mp+300278@xxxxxxxxxxxxxxxxxx
From: SirVer <SirVer@xxxxxx>
Date: Mon, 18 Jul 2016 07:16:24 -0000
In-reply-to: <20160717194227.22758.60562.launchpad@ackee.canonical.com>
Reply-to: mp+300278@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

I agree this is an improvement. One nit though: I think INVALID_INDEX == -1, but I cannot check. If that is the case, the first condition in the OR can be removed. 

Otherwise lgtm.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1603763/+merge/300278
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1603763.

References

[Merge] lp:~widelands-dev/widelands/bug-1603763 into lp:widelands
From: TiborB, 2016-07-17