widelands-dev team mailing list archive

[SirVer <SirVer@xxxxxx>]

Review: Approve

the metaserver executes only these two queries: 

select password from wlggz_ggzauth where user_id=?
select permissions from wlggz_ggzauth where user_id=? 

so your assessment is correct, only user_id, permissions and password are ever read. 

I'd vote for removing the fields - since they are unused removing them will reveal the real structure of the code better and allow us to refactor eventually towards something that makes more sense. Unused code is always better deleted!

One nit in the comments below.


Diff comments:

> 
> === modified file 'local_settings.py.sample'
> --- local_settings.py.sample	2016-06-26 11:30:10 +0000
> +++ local_settings.py.sample	2016-07-31 12:32:05 +0000
> @@ -19,8 +19,40 @@
>  
>  
>  # The following are just dummy values, but needed defined
> +# To use the registration you have to create an API key pair
> +# See https://developers.google.com/recaptcha/docs/start
> +# You have to use 'localhost' as Domain
>  NORECAPTCHA_SITE_KEY = 'dummy'
>  NORECAPTCHA_SECRET_KEY = 'dummy'
>  
>  # The logo used for mainpage
>  LOGO_FILE = 'Logo_alpha.png'
> +
> +# Setting an email backend prevents 'connection refused' errors
> +# This Backend shows Emails in console
> +EMAIL_BACKEND = 'django.core.mail.backends.console.EmailBackend'

Add a comment that this is overwritte on the server to actually send email?

> +
> +# Uncomment 'LOGGING = {...}' for debugging purposes when you have set DEBUG=False.
> +# Use then in the code:
> +
> +# import logging
> +# log = logging.getLogger(__name__)
> +# log.info('Variable x: %s', x)
> +
> +# This prints the value for Variable 'x' to log.txt
> +
> +#LOGGING = {
> +#    'version': 1,
> +#    'disable_existing_loggers': False,
> +#    'handlers': {
> +#        'logfile': {
> +#            'level':'DEBUG',
> +#            'class':'logging.FileHandler',
> +#            'filename': bd + "/log.txt",
> +#        },
> +#    },
> +#    'root': {
> +#        'level': 'INFO',
> +#        'handlers': ['logfile']
> +#    },
> +#}


-- 
https://code.launchpad.net/~widelands-dev/widelands-website/cleanup_ggz/+merge/301588
Your team Widelands Developers is subscribed to branch lp:widelands-website.