← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands-website/move_minimaps into lp:widelands-website

 

I don't know what to do with the 'upload_to' property.

- for the map it is needed
- for the minimap it isn't needed

Defining this property for one file field and not on an other in models.py is imho not good. And at least this is a part of the model. What we can do is:

- Define the upload_to attribute for minimap (like it is)
- get the attributes value in wlmaps.forms.py like: upl_to = Map._meta.get_field('minimap').upload_to
- use 'upl_to' to set the minimap in forms.py 

Doing so we would have all the relevant values in models.py, and not one in models.py and one in forms.py. I think this would be better, but i am unsure. What do you think?
-- 
https://code.launchpad.net/~widelands-dev/widelands-website/move_minimaps/+merge/303493
Your team Widelands Developers is subscribed to branch lp:widelands-website.


References