widelands-dev team mailing list archive

[Klaus Halfmann <klaus.halfmann@xxxxxxxx>]

Review: Needs Fixing compile, test

This Drodown is missing a feature found in all normal GUIs:

when you click outside the dropdown it will NOT collapse, 
allowing the user to click somewhere else. 
This implementation will do nothing in this case.
So if I forgot that the Dropdown is open and click somwhere else
It seems stuck as I get no visual feedback what to do.
This may frustrate players upto a level where theey will kill the game.

In additon it does not collapse when pressing Escape, 
instead the complete dialog is canceled.


Sorry Gun.

Good work otherwise. I will continue to review the usage and code.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-536489-dropdown/+merge/306303
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-536489-dropdown.