widelands-dev team mailing list archive

[SirVer <SirVer@xxxxxx>]

Review: Approve



Diff comments:

> 
> === modified file 'compile.sh'
> --- compile.sh	2016-05-17 16:02:17 +0000
> +++ compile.sh	2016-09-14 18:27:13 +0000
> @@ -23,16 +23,22 @@
>  
>  
>  ## Option to avoid building and linking website-related executables.
> -NO_WEBSITE=0
> +BUILD_WEBSITE="ON"
> +BUILD_TRANSLATIONS="ON"
> +BUILDTYPE="Debug"
>  while [ "$1" != "" ]; do
> -  if [ "$1" = "--no-website" -o "$1" = "-n" ]; then
> -    NO_WEBSITE=1
> +  if [ "$1" = "--no-website" -o "$1" = "-w" ]; then

I think 'website-related' is a little narrow. How about auxiliary or utility executables?

> +    BUILD_WEBSITE="OFF"
> +  elif [ "$1" = "--release" -o "$1" = "-r" ]; then
> +    BUILDTYPE="Release"
> +  elif [ "$1" = "--no-translations" -o "$1" = "-t" ]; then
> +    BUILD_TRANSLATIONS="OFF"
>    fi
>    shift
>  done
> -if [ $NO_WEBSITE -eq 0 ]; then
> +if [ $BUILD_WEBSITE = "ON" ]; then
>    echo "A complete build will be created."
> -  echo "You can use -n or --no-website to omit building and"
> +  echo "You can use -w or --no-website to omit building and"
>    echo "linking website-related executables."
>  else
>    echo "Any website-related code will be OMITTED in the build."


-- 
https://code.launchpad.net/~widelands-dev/widelands/compile_switches/+merge/304858
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/compile_switches.