widelands-dev team mailing list archive

[SirVer <SirVer@xxxxxx>]

Review: Approve

1) Is it necessary that we ship the askimet client in our repo, i.e. can it not be installed wia pip_requirements.txt? We definitively should remove the .svn directory if possible. Also, for this branch it is completely unused, so I actually now agree with #1 and suggest removing the API for now.

2) I was also changing hided -> hidden, at the very same time than Gun - but she beat me to submitting :). 

3) You should also check in the title of the post, not only the body. We had some spam that only had data in the title. You can do that cheaply by just concatenating: text = title + body and then working over text. 

4) It might make sense to add a regular expression checking for international phone numbers - I do not think such a post can ever be legit. 

5) You are marking any post of a user with 'ji' in its name as SPAM. Is that not a bit too broad?

6) There is no admin notification right now - so we will not know if posts are in the queue for moderation. I think that is fine for now, but we will need to remember to check daily once this is deployed until we have that. I am all for deploying this soon though, this SPAM is annoying. 
-- 
https://code.launchpad.net/~widelands-dev/widelands-website/anti_spam/+merge/307869
Your team Widelands Developers is subscribed to branch lp:widelands-website.