← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/zoom into lp:widelands

 

Excellent code review - thanks for that! I applied everything except for one thing:

> move set_owner to superclass as well, where get_owner() is now.

I considered this - but set_owner has different implementations in different classes and makes no sense for some MapObjects (that can never be owned). So I left it in the classes where it was defined. 

Bunnybot should be all ready for action again too - and it should now deal fine with many branches.
-- 
https://code.launchpad.net/~widelands-dev/widelands/zoom/+merge/309086
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/zoom.


References