← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/oars_appdata_b19 into lp:widelands/build19

 

We once broke a rc due to a bug in an image and another time due to a bug in translations. Both times we argued similarly. I am against pushing this into b19 and potentially break something for gnome users. It also seems not an urgent feature, just nice to have. 

> Am 29.10.2016 um 08:59 schrieb GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>:
> 
> GunChleoc has proposed merging lp:~widelands-dev/widelands/oars_appdata_b19 into lp:widelands/build19.
> 
> Commit message:
> Added age ratings to Appdata https://odrs.gnome.org/oars
> 
> Requested reviews:
>  Widelands Developers (widelands-dev)
> 
> For more details, see:
> https://code.launchpad.net/~widelands-dev/widelands/oars_appdata_b19/+merge/309625
> 
> Since this doesn't affect any runnable code, I am in favor of getting this into Build 19.
> -- 
> Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/oars_appdata_b19 into lp:widelands/build19.
> === modified file 'debian/widelands.appdata.xml' --- debian/widelands.appdata.xml	2016-10-25 06:07:19 +0000 +++ debian/widelands.appdata.xml	2016-10-29 06:58:26 +0000 @@ -211,7 +211,6 @@ https://wl.widelands.org/ widelands-dev_at_lists.launchpad.net - @@ -237,3 +236,25 @@ https://wl.widelands.org/wiki/Game%20Manual/ The Widelands Development Team + + moderate + none + none + none + none + mild + none + none + none + none + none +  none + none + intense + none + none + none + none + none + none + === modified file 'debian/widelands.appdata.xml.stub' --- debian/widelands.appdata.xml.stub	2016-10-25 06:07:19 +0000 +++ debian/widelands.appdata.xml.stub	2016-10-29 06:58:26 +0000 @@ -31,7 +31,6 @@ https://wl.widelands.org/ widelands-dev_at_lists.launchpad.net - @@ -57,3 +56,25 @@ https://wl.widelands.org/wiki/Game%20Manual/ The Widelands Development Team + + moderate + none + none + none + none + mild + none + none + none + none + none +  none + none + intense + none + none + none + none + none + none +
> _______________________________________________
> Mailing list: https://launchpad.net/~widelands-dev
> Post to     : widelands-dev@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~widelands-dev
> More help   : https://help.launchpad.net/ListHelp


-- 
https://code.launchpad.net/~widelands-dev/widelands/oars_appdata_b19/+merge/309625
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/oars_appdata_b19 into lp:widelands/build19.


References