widelands-dev team mailing list archive

[SirVer <SirVer@xxxxxx>]

Review: Disapprove

In my memory deadlocking AI was the norm in b17 and very frequent in b18. That people complain about it happening now in places is a sign that this has changed - which is a testament to Tibor's work! Great job!

I think this is not such a big deal as people make it out to be. The AI deadlocks sometimes - so what? The ship's transportation logic and the soldier's fighting bugs are at least as annoying in game, but there is no vocal voice complaining about it. There is also a starting condition specifically meant to help out the AI - so players can actually do something about it themselves. 

Adding a logic change at this point in the release cycle means that if this goes in, we need another RC - and rigorous testing for at least 3 weeks or so - and a special call out to the community to test this specific change. If we add a breaking bug in here we are stuck with it for years. Even if we release b20 earlier than our usual 2 years, linux distributions will not update LTS releases and people will complain about it. 

Just increasing the logs seems less risky but as mentioned multiple times seemingly simple changes have broken us in the past. I would not do that too - and if we do, it still warrants the extra testing in a rc2.

I think this is not worth it, but I will not block if that is what you want to do. 

-- 
https://code.launchpad.net/~widelands-dev/widelands/prevent_ai_deadlocks/+merge/309727
Your team Widelands Developers is subscribed to branch lp:widelands/build19.