widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~janosch-peters/widelands/bug-1638890-segfault-harbour into lp:widelands

To: Janosch Peters <janosch.peters@xxxxxxxxx>
From: TiborB <tiborb95@xxxxxxxxx>
Date: Fri, 04 Nov 2016 21:10:10 -0000
In-reply-to: <20161104181038.24611.3001.launchpad@ackee.canonical.com>
Reply-to: mp+310092@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

I would be very carefull with such changes close to release - if this is intended for B19. This can backfire badly. And testing with savegame is not enough. Problem with this stuff is that problematic conditions happens very rarely - so a lot of gametime is needed to gain some trust that this is OK. So I would consider how much time we have till the release...
-- 
https://code.launchpad.net/~janosch-peters/widelands/bug-1638890-segfault-harbour/+merge/310092
Your team Widelands Developers is requested to review the proposed merge of lp:~janosch-peters/widelands/bug-1638890-segfault-harbour into lp:widelands.

References

[Merge] lp:~janosch-peters/widelands/bug-1638890-segfault-harbour into lp:widelands
From: Janosch Peters, 2016-11-04