widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/casern_workersqueue into lp:widelands

To: mp+309763@xxxxxxxxxxxxxxxxxx
From: GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 09 Nov 2016 06:27:06 -0000
In-reply-to: <20161101144224.23743.48902.launchpad@ackee.canonical.com>
Reply-to: mp+309763@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

First round of code review is done - see my last commit.

I will have to look into your economy questions - I'm not really familiar with the economy code myself yet.

Great contribution overall! I have mostly some minors nits and refactoring ideas - feel free to drop any of those if you don't agree or turn them into TODO comments if you think the changes would be too big for this branch.
-- 
https://code.launchpad.net/~widelands-dev/widelands/casern_workersqueue/+merge/309763
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/casern_workersqueue into lp:widelands.

References

[Merge] lp:~notabilis27/widelands/casern into lp:widelands
From: Notabilis, 2016-11-01