widelands-dev team mailing list archive

[SirVer <SirVer@xxxxxx>]

My opinion: great change! Thanks for refactoring.

At work we have a loose rule that no function should be longer than 50 lines and no file longer than 1000 lines. This forces to think in modules, to reduce coupling between components and to implement in small pieces that are easy to understand on their own. This change moves into that direction, so I like it! :)

If you can also split the library in CMakeLists.txt into 2 (or more) that do not have cyclic dependencies, this might even speed up compilation. 


-- 
https://code.launchpad.net/~widelands-dev/widelands/ai_seafaring_split/+merge/311544
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ai_seafaring_split.