← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/compiler_warnings_201611 into lp:widelands

 

I know, I shouldn't, but anyway: I only looked at the diff and most of it looks good. I do not like the change in network.h, though. I am not sure about it, but isn't the constructor taking the address of a temporary?
-- 
https://code.launchpad.net/~widelands-dev/widelands/compiler_warnings_201611/+merge/311329
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/compiler_warnings_201611 into lp:widelands.


References