widelands-dev team mailing list archive
-
widelands-dev team
-
Mailing list archive
-
Message #08930
Re: [Merge] lp:~widelands-dev/widelands/bug-collectors into lp:widelands
Merging trunk is fine by me but I am not sure about your comments.
I tried it with only one call of set_textdomain("win_conditions") at the beginning of the function. However, this does not translate the "Game over" string. When it should include the widelands-domain it does not seem to be working. None of the other win conditions seem to use the widelands-strings, though.
I am not completely sure what you mean with moving a part down. Assuming that you want to move the "if m > 0 then" clause further down, it won't work since the result (value of $time) of this clause is used inside the "if h > 0" clause.
Another, minor, thing: Should there be a period after "Game over"?
--
https://code.launchpad.net/~widelands-dev/widelands/bug-collectors/+merge/312092
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-collectors.
References