widelands-dev team mailing list archive

[SirVer <SirVer@xxxxxx>]

Review: Approve

lgtm, but one comment:

// If this isn't here, we get a compiler warning in Windows. If it is, we get a compiler
// warning in clang. There is no natural default for this function.

Maybe we should tweak our warnings instead of changing the code. All our warning definitions are defined here: 
http://bazaar.launchpad.net/~widelands-dev/widelands/trunk/view/8191/CMakeLists.txt#L149

We could also disable some warnings specifically on Windows using if (WIN32). This would be all in one place instead all over the code base.
-- 
https://code.launchpad.net/~widelands-dev/widelands/compiler_warnings_201611/+merge/311329
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/compiler_warnings_201611.