widelands-dev team mailing list archive

[SirVer <SirVer@xxxxxx>]

Review: Approve

one nit, otherwise code lgtm. Ship it!! :)

Diff comments:

> 
> === modified file 'wl_utils.py'
> --- wl_utils.py	2016-11-15 22:47:15 +0000
> +++ wl_utils.py	2016-12-01 20:50:46 +0000
> @@ -1,4 +1,5 @@
>  
> +# Get the real IP when the Django server runs behind a proxy

redundant comment, already mentioned in the docstring

>  def get_real_ip(request):
>      """Returns the real user IP, even if behind a proxy."""
>      for key in ('HTTP_X_FORWARDED_FOR', 'REMOTE_ADDR'):


-- 
https://code.launchpad.net/~widelands-dev/widelands-website/wlimages_rework/+merge/311985
Your team Widelands Developers is subscribed to branch lp:widelands-website.