widelands-dev team mailing list archive

[SirVer <SirVer@xxxxxx>]

Review: Approve

same nit as kaputtnik had, otherwise lgtm.

Diff comments:

> === added file '_ops/fix_formatting.py'
> --- _ops/fix_formatting.py	1970-01-01 00:00:00 +0000
> +++ _ops/fix_formatting.py	2016-12-07 11:00:51 +0000
> @@ -0,0 +1,48 @@
> +#!/usr/bin/env python
> +# -*- coding: utf-8 -*-
> +
> +
> +"""This script runs pyformat over the code base.
> +"""
> +
> +import argparse
> +import os
> +import re
> +import sys
> +from subprocess import call
> +
> +PYTHON3 = sys.version_info >= (3, 0)

unused? Remove!

> +
> +def parse_args():
> +    p = argparse.ArgumentParser(
> +        description='Run pyformat over the code base.'
> +        ' Recurses over all relevant files.')
> +    return p.parse_args()
> +
> +
> +def find_files(startpath, extensions):
> +    for (dirpath, _, filenames) in os.walk(startpath):
> +        for filename in filenames:
> +            if os.path.splitext(filename)[-1].lower() in extensions:
> +                yield os.path.join(dirpath, filename)
> +
> +
> +def main():
> +    parse_args()
> +
> +    if not os.path.isdir('pybb') or not os.path.isdir('_ops'):
> +        print('CWD is not the root of the repository.')
> +        return 1
> +
> +    sys.stdout.write('\nFormatting Python code ')
> +    for filename in find_files('.', ['.py']):
> +        sys.stdout.write('.')
> +        sys.stdout.flush()
> +        call(['pyformat', '-i', filename])
> +    print(' done.')
> +
> +    print ('Formatting finished.')
> +    return 0
> +
> +if __name__ == '__main__':
> +    sys.exit(main())


-- 
https://code.launchpad.net/~widelands-dev/widelands-website/pyformat_util/+merge/312427
Your team Widelands Developers is subscribed to branch lp:widelands-website.