widelands-dev team mailing list archive

[GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>]

Review: Approve

Code LGTM, not tested. Some tiny nits.

Diff comments:

> 
> === modified file 'src/logic/map_objects/immovable.h'
> --- src/logic/map_objects/immovable.h	2016-11-22 19:11:01 +0000
> +++ src/logic/map_objects/immovable.h	2016-12-14 22:13:01 +0000
> @@ -202,9 +202,10 @@
>  	MO_DESCR(ImmovableDescr)
>  
>  public:
> -	/// If this immovable was created by a building, 'former_building' can be set in order to display
> +	/// If this immovable was created by a building, 'former_building_desr' can be set in order to display

desr -> descr

>  	/// information about it.
> -	Immovable(const ImmovableDescr&, const Widelands::Building* former_building = nullptr);
> +	Immovable(const ImmovableDescr&,
> +	          const Widelands::BuildingDescr* former_building_descr = nullptr);
>  	~Immovable();
>  
>  	Coords get_position() const {
> 
> === modified file 'src/logic/map_objects/tribes/building.cc'
> --- src/logic/map_objects/tribes/building.cc	2016-12-03 13:32:28 +0000
> +++ src/logic/map_objects/tribes/building.cc	2016-12-14 22:13:01 +0000
> @@ -239,6 +239,7 @@
>  }
>  
>  Building::~Building() {
> +	log("#sirver Destroying building this: %p\n", this);

#sirver Destroying building - this:

I expect you left this in for testing?

>  	if (optionswindow_)
>  		hide_options();
>  }


-- 
https://code.launchpad.net/~widelands-dev/widelands/bad_cast/+merge/313283
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bad_cast.