widelands-dev team mailing list archive

[GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>]

GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1627537-window-mouserelease into lp:widelands.

Commit message:
Let UI::Window only handle mouserelease when it actually handles it.

Requested reviews:
  Widelands Developers (widelands-dev)
Related bugs:
  Bug #1627537 in widelands: "Editor: Release mouse button does not work when placing things and mouse gets under a window"
  https://bugs.launchpad.net/widelands/+bug/1627537

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1627537-window-mouserelease/+merge/313700

This should fix the linked bug - I can't compile right now, so this is completely untested.
-- 
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1627537-window-mouserelease into lp:widelands.

=== modified file 'src/ui_basic/window.cc'
--- src/ui_basic/window.cc	2016-11-23 08:31:25 +0000
+++ src/ui_basic/window.cc	2016-12-21 14:14:53 +0000
@@ -387,8 +387,9 @@
 	if (btn == SDL_BUTTON_LEFT) {
 		grab_mouse(false);
 		dragging_ = false;
+		return true;
 	}
-	return true;
+	return false;
 }
 
 // Always consume the tooltip event to prevent tooltips from