← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/animation_manager into lp:widelands

 

Review: Resubmit

> widelands: /var/widelands/BZR/animation_manager/src/sound/sound_handler.cc:433: void SoundHandler::play_fx(const string&, int32_t, uint8_t): Assertion `stereo_pos >= -1' failed.

This is fixed now. The fix was slightly involved, so more testing would be nice. 

> If the keyboard shortcuts '.' and ',' are removed, please remove also the description for keyboard shortcuts (data/tribes/scripting/help/controls.lua).

Done.

> What I meant was that if you hit 'Go to ....', it zooms out (goes to the distance) and stays there, without coming close to the relevant spot...

I cannot reproduce this. Could you provide a savegame with a message that shows this behavior?
-- 
https://code.launchpad.net/~widelands-dev/widelands/animation_manager/+merge/313879
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/animation_manager.


References