widelands-dev team mailing list archive

[kaputtnik <somal@xxxxxxxx>]

Puhh... hopefully i get it now. Giving the example of 

1. https://wl.widelands.org/wiki/Description/
2. https://wl.widelands.org/wiki/GameHelp/  #redirect to 1.

- Trying to open /wiki/edit/GameHelp opens now 'Description' for editing.

Trying to change the title is handled as follows:

For existing articles those circumstances are prevented and a message is shown in the form:
- If the title is in a changeset (so redirects and old links will not break)
- If the title already exists as normal article (handled in wiki/forms.py)

For new articles:
- If one opens /wiki/edit/foo and immediately wants to rename it to 'bar' without saving first, the previous checks are also done. There is one difference: If 'bar' exists as normal article, django checks this on database level, a message is then also shown in the form.

I think this is ready but want to make a last test in the next days. A question:
I am unsure about a nested 'try: ... except:' clause. Is this good coding practice? See:

http://bazaar.launchpad.net/~widelands-dev/widelands-website/bug-1399461_error_on_renaming_article/view/head:/wiki/views.py#L262
-- 
https://code.launchpad.net/~widelands-dev/widelands-website/bug-1399461_error_on_renaming_article/+merge/314033
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands-website/bug-1399461_error_on_renaming_article into lp:widelands-website.