← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/switch_direction into lp:widelands

 

Review: Needs Fixing

This is the desired change requested in the above bug. I am actually against merging this, because the change in direction feels unnatural to me. 

The problem is that terminating the in-progress movement and starting a new one resets the movement speed to 0. This makes the change in direction very 'jumpy' and unexpected. The correct solution for this would be to calculate a path that is smooth in its change of velocities - that is very complicated though and would add quite some code and math. I do not think the tradeoff is a good one. 

I still favor my original choice of letting each planned animation play out to completion before starting the next one.  
-- 
https://code.launchpad.net/~widelands-dev/widelands/switch_direction/+merge/315432
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/switch_direction.


References