widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/disambiguate_production_program_names into lp:widelands

To: mp+316933@xxxxxxxxxxxxxxxxxx
From: Notabilis <notabilis27@xxxxxx>
Date: Sat, 11 Feb 2017 21:03:15 -0000
In-reply-to: <20170210094722.19962.11881.launchpad@ackee.canonical.com>
Reply-to: mp+316933@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

I only looked at the diff and the lua-changes look good to me. I also like the extended documentation.
I can't say much about the source code change. The code itself looks okay but I have no idea what exactly _() and pgettext_exp() are doing.
-- 
https://code.launchpad.net/~widelands-dev/widelands/disambiguate_production_program_names/+merge/316933
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/disambiguate_production_program_names into lp:widelands.

References

[Merge] lp:~widelands-dev/widelands/disambiguate_production_program_names into lp:widelands
From: GunChleoc, 2017-02-10