widelands-dev team mailing list archive

[SirVer <SirVer@xxxxxx>]

Review: Needs Fixing



Diff comments:

> 
> === modified file 'src/network/internet_gaming_messages.cc'
> --- src/network/internet_gaming_messages.cc	2017-01-25 18:55:59 +0000
> +++ src/network/internet_gaming_messages.cc	2017-02-10 15:40:11 +0000
> @@ -40,26 +40,10 @@
>  void InternetGamingMessages::fill_map() {
>  	// messages from metaserver to client
>  	igmessages["NO_SUCH_USER"] = _("There is no user with the name %s logged in!");
> -	igmessages["WRONG_PASSWORD"] = _("The sent password was incorrect!");

pretty sure all of these are needed. This is translating between the metaserver replies and real text.

To check what is used, clone https://github.com/widelands/widelands_metaserver and grep for the CAPITAL_TEXT. Pretty sure all of it is used somewhere.

> -	igmessages["UNSUPPORTED_PROTOCOL"] = _("The protocol version you are using is not supported!");
> -	igmessages["ALREADY_LOGGED_IN"] = _("You are already logged in!");
> -	igmessages["DEFICIENT_PERMISSION"] =
> -	   _("You got disconnected, as you sent a superuser command without superuser permission. "
> -	     "This incident will be logged and reported to the administrator.");
> -	igmessages["RESTARTING"] = _("You got disconnected, as the metaserver is currently restarting.");
>  	// messages from client to metaserver
>  	igmessages["CONNECTION_CLOSED"] = _("Connection was closed by the client normally.");
>  	igmessages["CONNECTION_LOST"] = _("The connection to the metaserver was lost.");
>  	igmessages["NO_ANSWER"] = _("Metaserver did not answer");
> -	igmessages["GAME_NOT_CONNECTABLE"] = _("Your game can’t be connected to from the internet");
>  	igmessages["CLIENT_TIMEOUT"] =
>  	   _("You got disconnected from the metaserver, as you did not answer a PING request in time.");
> -	igmessages["GAME_TIMEOUT"] =
> -	   _("The metaserver was unable to connect to your game. Most likely it can’t be connected to "
> -	     "from the "
> -	     "internet! Please take a look at http://wl.widelands.org/wiki/InternetGaming to learn how "
> -	     "to set up "
> -	     "your internet connection for hosting a game online.");
> -	igmessages["NOT_LOGGED_IN"] = _(
> -	   "You tried to log back in, but the server has no knowledge of your previous state anymore.");
>  }


-- 
https://code.launchpad.net/~widelands-dev/widelands/cleanup-networking-messages/+merge/316974
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/cleanup-networking-messages.