← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/align-align into lp:widelands

 

Review: Resubmit

Gun: are you sure about changing alignement of Textarea, WordWrap and RenderTarget to HAlign only?

void Textarea::draw() uses H and VAlignent, so text _can_ be centered vertically.
Same for WordWrap:draw() and RenderTarget::blit().

Doing this will introduce a semantic change we should adress in a seperate branch.
Can we go with my changes now and adress your wishes later?

I am not done checking all your comments, but lets check if Travis and Appveyor are happy now.
-- 
https://code.launchpad.net/~widelands-dev/widelands/align-align/+merge/317871
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/align-align.


References