widelands-dev team mailing list archive

[GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>]

GunChleoc has proposed merging lp:~widelands-dev/widelands/align-cleanup-box into lp:widelands.

Commit message:
Refactored UI::Box::add():
- Bumped align argument to the back, because it is the least needed parameter.
- Replaced bool fullsize and bool fillspace with new enum class Resizing { kAlign, kFullSize, kFillSpace, kExpandBoth };

Requested reviews:
  Widelands Developers (widelands-dev)

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/align-cleanup-box/+merge/318305

This is a follow-up branch to Hasi's align cleanup which gets rid of most mentions of UI::Align in calls to UI::Box::add().

I also replaced the two bool arguments in that function with an enum class, because I always found the function hard to understand. Better ideas for naming the enum class members are welcome :)
-- 
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/align-cleanup-box into lp:widelands.