← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/align-cleanup-box into lp:widelands

 

Review: Approve compile, review, test

Ahh, Good to get rid of this difficult to grasp boolean parameters.

Code is fine for me (for some reason the locations are well known ;-)

"Watch replay" fails, after opening the ediotr, with Assertion failed: (lborder_ + rborder_ <= w_), function get_inner_w, file /Users/klaus/develop/widelands-repo/align-cleanup-box/src/ui_basic/panel.h, line 184. I assume some unintialized memory conditon hits us here?

Started with ./widelands --xres=1024 --yres=768

Same when opening the Multiplayermode via the explicit login dialog.

Still I approve _this_ change, but now lets get rid of these layouting assertion.



-- 
https://code.launchpad.net/~widelands-dev/widelands/align-cleanup-box/+merge/318315
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/align-cleanup-box.


References