widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/wincondition_dropdown_multiplayer into lp:widelands

To: mp+322196@xxxxxxxxxxxxxxxxxx
From: GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>
Date: Sun, 09 Apr 2017 08:21:07 -0000
In-reply-to: <20170407120324.14091.6047.launchpad@ackee.canonical.com>
Reply-to: mp+322196@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

OK, I'll need to have another look when I am back home. I merged trunk in a slooow and tiny VM window, so I didn't notice the conflicts during testing. Thanks for the reviews so far!

And yes, I shifted common functions into a superclass to avoid code duplication.
-- 
https://code.launchpad.net/~widelands-dev/widelands/wincondition_dropdown_multiplayer/+merge/322196
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/wincondition_dropdown_multiplayer.

References

[Merge] lp:~widelands-dev/widelands/wincondition_dropdown_multiplayer into lp:widelands
From: GunChleoc, 2017-04-07