widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/fh1_width_and_mapobject_messages into lp:widelands

To: mp+318189@xxxxxxxxxxxxxxxxxx
From: SirVer <SirVer@xxxxxx>
Date: Tue, 25 Apr 2017 05:17:02 -0000
In-reply-to: <20170224092535.20421.42895.launchpad@ackee.canonical.com>
Reply-to: mp+318189@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Looking over the code, a few comments:

1) What is up with barbarians/warehouse/representative image? Why is this only for the barbarian warehouse in this branch?
2) I made DesiredWidth a struct, since it always appeared in a tuple of (int, unit).
3) I found a memory leak that needs fixing.

All comments are in code as NOCOM. 

-- 
https://code.launchpad.net/~widelands-dev/widelands/fh1_width_and_mapobject_messages/+merge/318189
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fh1_width_and_mapobject_messages.

References

[Merge] lp:~widelands-dev/widelands/fh1_width_and_mapobject_messages into lp:widelands
From: GunChleoc, 2017-02-24