widelands-dev team mailing list archive

[SirVer <SirVer@xxxxxx>]

This is a const issue. Const Image vs (nonconst) texture. Just a guess - I am on mobile and can't decipher the code. 

> Am 30.04.2017 um 19:22 schrieb Klaus Halfmann <klaus.halfmann@xxxxxxxx>:
> 
> Sorry, still does not like it, Attaching the complete messages, maybe it can help you
> 
> ... bzr+ssh://bazaar.launchpad.net/~widelands-dev/widelands/fh1_width_and_mapobject_messages/
> M  src/wui/waresdisplay.cc                                                                                                                                     
> Alle Änderungen erfolgreich angewendet.                                                                                                                         
> Now on revision 8318.
> $ ./compile.sh 
> 
> [ 45%] Building CXX object src/graphic/CMakeFiles/graphic.dir/animation.cc.o
> fh1_width_and_mapobject_messages/src/graphic/animation.cc:156:22: warning: implicit conversion increases floating-point
>      precision: 'float' to 'double' [-Wdouble-promotion]
>                                                 scale_, image_files_[0].c_str());
>                                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> fh1_width_and_mapobject_messages/src/base/wexception.h:60:56: note: expanded from macro 'wexception'
> #define wexception(...) WException(__FILE__, __LINE__, __VA_ARGS__)
>                        ~~~~~~~~~~                     ^~~~~~~~~~~
> fh1_width_and_mapobject_messages/src/graphic/animation.cc:232:9: error: no viable conversion from returned value of type
>      'unique_ptr<Texture>' to function return type 'unique_ptr<const Image>'
>        return rv;
>               ^~
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:2565:29: note: candidate constructor
>      (the implicit copy constructor) not viable: no known conversion from 'std::unique_ptr<Texture>' to 'const std::__1::unique_ptr<const Image,
>      std::__1::default_delete<const Image> > &' for 1st argument
> class _LIBCPP_TYPE_VIS_ONLY unique_ptr
>                            ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:2594:49: note: candidate constructor not viable:
>      no known conversion from 'std::unique_ptr<Texture>' to 'nullptr_t' for 1st argument
>    _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR unique_ptr(nullptr_t) _NOEXCEPT
>                                                ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:2621:31: note: candidate constructor not viable:
>      no known conversion from 'std::unique_ptr<Texture>' to 'std::__1::unique_ptr<const Image, std::__1::default_delete<const Image> > &&' for 1st argument
>    _LIBCPP_INLINE_VISIBILITY unique_ptr(unique_ptr&& __u) _NOEXCEPT
>                              ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:2625:9: note: candidate constructor [with _Up =
>      Texture, _Ep = std::__1::default_delete<Texture>] not viable: no known conversion from 'std::unique_ptr<Texture>' to 'unique_ptr<Texture,
>      std::__1::default_delete<Texture> > &&' for 1st argument
>        unique_ptr(unique_ptr<_Up, _Ep>&& __u,
>        ^
> /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:2640:35: note: candidate template ignored: could
>      not match 'auto_ptr' against 'unique_ptr'
>        _LIBCPP_INLINE_VISIBILITY unique_ptr(auto_ptr<_Up>&& __p,
>                                  ^
> fh1_width_and_mapobject_messages/src/graphic/animation.cc:339:27: warning: moving a temporary object prevents copy elision
>      [-Wpessimizing-move]
>                   std::make_pair(hash, std::move(g_gr->animations().get_animation(id).representative_image(clr))));
>                                        ^
> fh1_width_and_mapobject_messages/src/graphic/animation.cc:339:27: note: remove std::move call here
>                   std::make_pair(hash, std::move(g_gr->animations().get_animation(id).representative_image(clr))));
>                                        ^~~~~~~~~~                                                              
> 
> -- 
> https://code.launchpad.net/~widelands-dev/widelands/fh1_width_and_mapobject_messages/+merge/318189
> You are reviewing the proposed merge of lp:~widelands-dev/widelands/fh1_width_and_mapobject_messages into lp:widelands.


-- 
https://code.launchpad.net/~widelands-dev/widelands/fh1_width_and_mapobject_messages/+merge/318189
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fh1_width_and_mapobject_messages.