← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands-website/notifications_cleanup into lp:widelands-website

 

Thanks for testing and review :-)

Got also all emails (except for the server error).

Deferred vs. Immediate mails: I have tried to use deferred mails for things where 'maybe' much people get informed. I just guessed that most people are interested in getting e-mails for new maps, topics and forum-posts. When sending a message or on changes in wiki there are only a few people involved and a few mails are send immediately then.

Wlmaps -> Maps: This string is cut from the label of a notice type. So wlmaps_new_map is turned into 'Wlmaps' and forum_new_topic get 'Forum'. I thought it is intended to start the label with the name of the app which it relates to. But i am fine with 'maps_new_map' as the label for the notice type. I want also to reverse the ordering so we have an alphabetical order of headings: 1. Forum, 2. Maps, 3. Messages, 4. Wiki

Map upload: The process of uploading the map take a very long time. I think this is because of wl_map_info needs long time to process the map. The timeout you had is maybe because you uploaded a big map? No idea for the server error though.

Pickling: The pickled object is already stored in the database. The model for this is 'NoticeQueueBatch' 

http://bazaar.launchpad.net/~widelands-dev/widelands-website/notifications_cleanup/view/head:/notification/models.py#L117

Are you fine with running emit_notices hourly?
-- 
https://code.launchpad.net/~widelands-dev/widelands-website/notifications_cleanup/+merge/323457
Your team Widelands Developers is subscribed to branch lp:widelands-website.


References