widelands-dev team mailing list archive

[Hans Joachim Desserud <launchpad@xxxxxxxxxxxx>]

Hans Joachim Desserud has proposed merging lp:~widelands-dev/widelands/gcc7 into lp:widelands.

Requested reviews:
  Widelands Developers (widelands-dev)

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/gcc7/+merge/323576

(Note: at the moment this is mainly for testing, not merging. I think branches need a merge proposal in order to find build results from bunnybot, right?)

I don't remember the details, but we didn't add GCC7 in the last round of compiler updates due to some issue. Since then, Ubuntu has done a rebuild of the whole archive with GCC7 [1], and Widelands was among the build failures [2]. GCC 7.1 has now been officially released [3], so it is likely only a question of time before it becomes the default compiler on a lot of systems.

I pushed this branch now to check if we still have a build failure in the development version and if we do, it should naturally be fixed. It isn't unlikely that someone will look for a similar patch for build19 too in the future, so we should probably mark it in such a way that it is easily findable. Could save people some time and duplicated work, assuming the code hasn't changed too much in the meantime. For instance, distros tend to treat build failures pretty seriously since if they cannot build the package it becomes impossible to ship patches or updates to it so they will want to keep build19 buildable.

[1] more details on https://lists.ubuntu.com/archives/ubuntu-devel/2017-March/039749.html
[2] http://qa.ubuntuwire.org/ftbfs/rebuilds/test-rebuild-20170322.1-gcc7-zesty.html
[3] https://gcc.gnu.org/gcc-7/
-- 
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/gcc7 into lp:widelands.

=== modified file '.travis.yml'
--- .travis.yml	2017-02-13 17:15:49 +0000
+++ .travis.yml	2017-05-03 19:39:51 +0000
@@ -36,14 +36,14 @@
      - compiler: gcc
        env: GCC_VERSION="4.9" BUILD_TYPE="Debug"
      - compiler: gcc
-       env: GCC_VERSION="5" BUILD_TYPE="Debug"
-     - compiler: gcc
        env: GCC_VERSION="6" BUILD_TYPE="Debug"
      - compiler: gcc
+       env: GCC_VERSION="7" BUILD_TYPE="Debug"
+     - compiler: gcc
        env: GCC_VERSION="4.8" BUILD_TYPE="Release"
      - compiler: gcc
        env: GCC_VERSION="4.9" BUILD_TYPE="Release"
      - compiler: gcc
-       env: GCC_VERSION="5" BUILD_TYPE="Release"
-     - compiler: gcc
        env: GCC_VERSION="6" BUILD_TYPE="Release"
+     - compiler: gcc
+       env: GCC_VERSION="7" BUILD_TYPE="Release"