← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/savegame-menu into lp:widelands

 

Thanks for testing again :)

> Don't know if this related to your changes: 
> - Fullscreen toggling does not work for the save game menu, as well for Editor Load/Save map menu. But for me this is ok.

That's already broken in trunk and will be fixed with
https://code.launchpad.net/~widelands-dev/widelands/bug-1598588-fullscreen-wui


> - I have some incompatible maps showing an Error message. Hovering with the mouse over the errormessage shows the tooltip "The Map that this map is based on" of the map.

Needs fixing, thanks for pointing this out.


> - The tooltip is only shown when hovering exactly over the first line. 
> - In trunk there is also a tooltip for the Win Condition, which is missing here

Won't fix, because we no longer have a separarate GUI element to tie a
tooltip to. Except for the map name, it's all a big Multilinetextarea
now. Doesn't matter though as by your comment below that I agree with.


> General in regard to the tooltips when hovering "Map name" and "Win condition": I don't know if they are use full in the Load game menu, because they are telling the same as the texts already says. So they do not help in any way, but causes additional work for the translators, imho.

The Map name ones are still useful in general because of the
delocalizing option for map names when setting up a game - I'll do a
review of them though to see what can be removed.

-- 
https://code.launchpad.net/~widelands-dev/widelands/savegame-menu/+merge/322924
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/savegame-menu.


References