widelands-dev team mailing list archive

[GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>]

Code review done.

1. Please go over my changes with a fine-tooth comb to make sure that I haven't accidentally introduced any logic changes.

2. Was the test suite already broken, or did I break it with my changes?

3. We need to keep savegame compatibility until after Bzuild 20, so savegames will remain viable for bug fixing. I have added some code so that old savegames will load, but the games will segfault, because something still needs initializing. Since you know the code better than I, can you have a look?

4. We have a bunch of hard coded ware and building names that I'd like to get rid of. Turn anything that's too complicated to solve right now into a TODO comment, so that we can fix it in a follow-up branch.

5. I found a bunch of commented out code lines, I left them in with a NOCOM comment so that you can decide if you still want them someplace.

6. I think we should have a command line switch for the training mode, so we won't have to recompile to switch modes. Let me know if you want me to take care of it.

Note that I will be unable to contribute code for a few weeks starting from Thursday next week, so if you want me to do any more coding in this branch, please let me know ASAP.

-- 
https://code.launchpad.net/~widelands-dev/widelands/ai-post-b19-2/+merge/325796
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/ai-post-b19-2 into lp:widelands.