widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/ai-post-b19-2 into lp:widelands

To: mp+325796@xxxxxxxxxxxxxxxxxx
From: GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>
Date: Sat, 24 Jun 2017 06:06:23 -0000
In-reply-to: <149759060511.2855.5651599525439052054.launchpad@ackee.canonical.com>
Reply-to: mp+325796@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

BTW comments like

  //Should happen only rarely so we print a warning here

will break codecheck, always use a blank space:

  // Should happen only rarely so we print a warning here

Regarding your question in the code, size_t is an unsigned type http://www.cplusplus.com/reference/cstddef/size_t/?kw=size_t
-- 
https://code.launchpad.net/~widelands-dev/widelands/ai-post-b19-2/+merge/325796
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/ai-post-b19-2 into lp:widelands.

References

[Merge] lp:~widelands-dev/widelands/ai-post-b19-2 into lp:widelands
From: GunChleoc, 2017-06-16