← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/codecheck into lp:widelands

 

2 nits:

In cmake/codecheck/rules/camel_case_for_classes:

    "Use CapitalLetterWithCamelCase when naming an enum class, struct, or \"using\".")

 -> "Use CapitalLetterWithCamelCase when naming an enum class, class, struct, or \"using\".")


src/build_info.h
 
/// \return the build id which is automagically created from the checkout's

-> checkouts (plural, not genitive)
-- 
https://code.launchpad.net/~widelands-dev/widelands/codecheck/+merge/326647
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/codecheck into lp:widelands.


References