widelands-dev team mailing list archive

[SirVer <SirVer@xxxxxx>]

Thanks for the review!

@bunnybot merge

Diff comments:

> 
> === modified file 'src/logic/cmd_luacoroutine.cc'
> --- src/logic/cmd_luacoroutine.cc	2017-01-25 18:55:59 +0000
> +++ src/logic/cmd_luacoroutine.cc	2017-07-05 21:50:35 +0000
> @@ -51,11 +53,11 @@
>  		log("%s\n", e.what());
>  		log("Send message to all players and pause game\n");
>  		for (int i = 1; i <= game.map().get_nrplayers(); i++) {
> -			Widelands::Message& msg = *new Widelands::Message(
> +			std::unique_ptr<Message >msg(new Widelands::Message(

Yes, I did not run it apparently.

>  			   Message::Type::kGameLogic, game.get_gametime(), "Coroutine",
>  			   "images/ui_basic/menu_help.png", "Lua Coroutine Failed",
> -			   (boost::format("<rt><p font-size=12>%s</p></rt>") % e.what()).str());
> -			game.player(i).add_message(game, msg, true);
> +			   (boost::format("<rt><p font-size=12>%s</p></rt>") % e.what()).str()));
> +			game.player(i).add_message(game, std::move(msg), true);
>  		}
>  		game.game_controller()->set_desired_speed(0);
>  	}


-- 
https://code.launchpad.net/~widelands-dev/widelands/00_private_inheritance/+merge/326886
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/00_private_inheritance.