widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/net-relay into lp:widelands

To: mp+327491@xxxxxxxxxxxxxxxxxx
From: GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>
Date: Mon, 24 Jul 2017 07:46:36 -0000
In-reply-to: <150020673935.7945.9607362151807768506.launchpad@ackee.canonical.com>
Reply-to: mp+327491@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

The protocol looks good to me.

There is no description of how the relay server get shut down yet, either in game end or when host and clients disappear without telling the relay about it.

I'd add a note to RLYCMD_TO_HOST that it's identical to RLYCMD_TO_CLIENT etc., to make the documentation easier to read.

There are also a bunch of commented out braces.
-- 
https://code.launchpad.net/~widelands-dev/widelands/net-relay/+merge/327491
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/net-relay into lp:widelands.

References

[Merge] lp:~widelands-dev/widelands/net-relay into lp:widelands
From: Notabilis, 2017-07-16