← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/ai_dna_dump into lp:widelands

 

@Gun, I implemented most of your comments (not uploaded right now), but few comments here:

>I think the output would be more readable with a blank space after each ,
It is compressed to fit into terminal line :) and indeed it is used only by me and is parsed by script when automatical training is done

>Why the static_cast? to_string can handle unsigned types.

In fact, it misbehaved for uint32_t - I was getting negative numbers 'inside' in generated strings, so I would leave it as it is now

Also, I will edit manually the headers of AI files before merge as I am still doing a training, I looked at  Profile::write() (the code that generates the first line) and it does not offer any customizability here...
-- 
https://code.launchpad.net/~widelands-dev/widelands/ai_dna_dump/+merge/327988
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/ai_dna_dump into lp:widelands.


Follow ups

References