widelands-dev team mailing list archive

[Klaus Halfmann <klaus.halfmann@xxxxxxxx>]

Review: Approve review

Looks all fine.
Checked the code for that unused num_failed.

Will compile and play this now ...

Diff comments:

> 
> === modified file 'src/map_io/s2map.cc'
> --- src/map_io/s2map.cc	2017-01-25 18:55:59 +0000
> +++ src/map_io/s2map.cc	2017-08-11 11:40:48 +0000
> @@ -1074,7 +1071,6 @@
>  				}
>  			} while (mr.advance(map_) && !fixed);
>  			if (!fixed) {
> -				++num_failed;

OK the is a reasonable stop condition here: while (mr.advance(map_)

>  				log("FAILED! No alternative port buildspace for (%i, %i) found!\n", fc.x, fc.y);
>  			} else
>  				log("Fixed!\n");


-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-986611-cppcheck-minimal/+merge/328910
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-986611-cppcheck-minimal.