widelands-dev team mailing list archive

[TiborB <tiborb95@xxxxxxxxx>]

I left a comment for you in the diff to one of your comments

Diff comments:

> 
> === modified file 'src/ai/defaultai.cc'
> --- src/ai/defaultai.cc	2017-08-01 12:03:03 +0000
> +++ src/ai/defaultai.cc	2017-08-15 08:22:00 +0000
> @@ -482,10 +482,15 @@
>  void DefaultAI::late_initialization() {
>  	player_ = game().get_player(player_number());
>  	tribe_ = &player_->tribe();
> +	if (game().is_ai_training_mode()) {
> +		ai_training_mode_ = true;
> +		management_data.set_ai_training_mode();
> +	}
>  	const uint32_t gametime = game().get_gametime();
>  
> -	log("ComputerPlayer(%d): initializing as type %u\n", player_number(),
> -	    static_cast<unsigned int>(type_));
> +	log("ComputerPlayer(%d): initializing as type %u%s\n", player_number(),
> +		 // NOCOM(#codereview): Please add blank spaces.

In fact it is by purpose note that candidate string starts with comma (',') so there should be no space before.....

> +	    static_cast<unsigned int>(type_), (ai_training_mode_)?", in ai training mode":"");
>  	if (player_->team_number() > 0) {
>  		log("    ... member of team %d\n", player_->team_number());
>  	}


-- 
https://code.launchpad.net/~widelands-dev/widelands/ai_training_switch/+merge/329008
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/ai_training_switch into lp:widelands.