widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/remove_make_infrastructure_tool into lp:widelands

To: mp+329201@xxxxxxxxxxxxxxxxxx
From: GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>
Date: Thu, 17 Aug 2017 14:09:08 -0000
In-reply-to: <150297724005.24251.5649022921858160239.launchpad@ackee.canonical.com>
Reply-to: mp+329201@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Code LGTM :)

TribeDescr:headquarters() is now unused, but we should use it in the collectors starting condition, where the identification of the warehouse types is somewhat hackish right now.

Will do a bit of testing just in case.
-- 
https://code.launchpad.net/~widelands-dev/widelands/remove_make_infrastructure_tool/+merge/329201
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/remove_make_infrastructure_tool.

References

[Merge] lp:~widelands-dev/widelands/remove_make_infrastructure_tool into lp:widelands
From: SirVer, 2017-08-17