widelands-dev team mailing list archive

[SirVer <SirVer@xxxxxx>]

SirVer has proposed merging lp:~widelands-dev/widelands/fix_drag_and_drop_in_editor into lp:widelands.

Commit message:
- Change MapView to never claim to fully have handle a mouse click. This guarantees that the event will bubble up to EditorInteractive. While semantically this is incorrect (since we do something on mouseclick), it should not hurt here since the MapView is always the bottom most panel and if it receives a click it means that no other UI::Panel's are in this spot except for the parent of MapView (i.e. EditorInteractive or *Interactive) which also wants to do something on click.
- Removed unused function and an unused variable.
- Remove useless overwrites in InteractiveBase. The UI code handles the correct calling order.


Requested reviews:
  Widelands Developers (widelands-dev)
Related bugs:
  Bug #1713255 in widelands: "Drag-and-drop no longer works in the editor"
  https://bugs.launchpad.net/widelands/+bug/1713255

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/fix_drag_and_drop_in_editor/+merge/330104
-- 
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/fix_drag_and_drop_in_editor into lp:widelands.