widelands-dev team mailing list archive

[GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>]

Code LTGM, except for 1 nit that has to be fixed - there's a string that should not end up on Transifex.

Not tested yet.

Diff comments:

> === added file 'data/tribes/buildings/markets/barbarians/market/helptexts.lua'
> --- data/tribes/buildings/markets/barbarians/market/helptexts.lua	1970-01-01 00:00:00 +0000
> +++ data/tribes/buildings/markets/barbarians/market/helptexts.lua	2017-09-15 17:55:38 +0000
> @@ -0,0 +1,27 @@
> +-- This include can be removed when all help texts have been defined.
> +include "tribes/scripting/help/global_helptexts.lua"
> +
> +function building_helptext_lore()
> +   -- TRANSLATORS#: Lore helptext for a building
> +   return no_lore_text_yet()
> +end
> +
> +function building_helptext_lore_author()
> +   -- TRANSLATORS#: Lore author helptext for a building
> +   return no_lore_author_text_yet()
> +end
> +
> +function building_helptext_purpose()
> +   -- TRANSLATORS: Purpose helptext for a building
> +   return pgettext("barbarians_building", "TODO: Document market once its use stabilizes.")

This will add this string to Transifex. Better add a comment about the TRANSLATORS comment and return and empty string.

> +end
> +
> +function building_helptext_note()
> +   -- TRANSLATORS#: Note helptext for a building
> +   return ""
> +end
> +
> +function building_helptext_performance()
> +   -- TRANSLATORS#: Performance helptext for a building
> +   return ""
> +end


-- 
https://code.launchpad.net/~widelands-dev/widelands/market/+merge/330830
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/market into lp:widelands.