← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~trimardio/widelands-website/scheduling into lp:widelands-website

 

First look:

create a base template and load the needed css and js files in there. This should be done in a block tag:

{% block extra_head %}
... load css and js
{% endblock %}

And in the other templates use then

{% extends "wlscheduling/base.html" %}

So loading those files are done in place and not in every template ;-)

Is there a reason why the model field is called 'hour' but it is a DateTime field? Something like:

if datetime.now() > a.hour:
    a.delete()

looks wired, imho.

- Have you tried using the css-class 'button' for the links on the main screen?
- Please try to use the css-class 'errormessage' for the Timezone related warning and remove the coloring of the div. A link to the profile page would be useful in the warning.
- The text of the link "Schedule when you're available and find a game" overlaps the black area -
when the browser window gets smaller.
-- 
https://code.launchpad.net/~trimardio/widelands-website/scheduling/+merge/330997
Your team Widelands Developers is requested to review the proposed merge of lp:~trimardio/widelands-website/scheduling into lp:widelands-website.


References