widelands-dev team mailing list archive

[SirVer <SirVer@xxxxxx>]

Review: Approve code review

Nice!

@bunnybot merge


Diff comments:

> 
> === modified file 'src/economy/shippingitem.cc'
> --- src/economy/shippingitem.cc	2017-01-25 18:55:59 +0000
> +++ src/economy/shippingitem.cc	2017-09-03 11:23:47 +0000
> @@ -129,19 +129,6 @@
>  	destination_dock_ = dynamic_cast<PortDock*>(next);
>  }
>  
> -void ShippingItem::schedule_update(Game& game, int32_t delay) {

surprising to me that this is unused....

> -	WareInstance* ware;
> -	Worker* worker;
> -	get(game, &ware, &worker);
> -
> -	if (ware) {
> -		ware->schedule_act(game, delay);
> -	}
> -	if (worker) {
> -		worker->send_signal(game, "wakeup");
> -	}
> -}
> -
>  /**
>   * Remove the underlying item directly. This is used when ships are removed.
>   */


-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-986611-cppcheck-mopup/+merge/329280
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-986611-cppcheck-mopup.