widelands-dev team mailing list archive

[GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>]

Review: Approve

Code LGTM, 1 nit. Not tested.

Diff comments:

> 
> === modified file 'src/ai/ai_help_structs.cc'
> --- src/ai/ai_help_structs.cc	2017-08-20 17:45:42 +0000
> +++ src/ai/ai_help_structs.cc	2017-09-20 17:28:07 +0000
> @@ -609,8 +609,16 @@
>  // Mutating, but all done on persistent data
>  void ManagementData::mutate(const uint8_t pn) {
>  
> +	// Below numbers are used to dictate intensity of mutation
> +	// Probability that a value will be mutated = 1 / probability
> +	// (lesser number means higher probability and higher mutation)
>  	int16_t probability =
>  	   shift_weight_value(get_military_number_at(kMutationRatePosition), false) + 101;
> +	// Some of mutation will be agressive - over full range of values, the number below
> +	// say how many (aproximately) they will be
> +	uint16_t prefferred_numbers_count = 0;

prefferred -> preferred

> +	// This is used to store status whether wild card was or was not used
> +	bool wild_card = false;
>  
>  	// When doing training mutation probability is to be bigger than not in training mode
>  	if (ai_training_mode_) {


-- 
https://code.launchpad.net/~widelands-dev/widelands/ai_differentiation/+merge/331085
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ai_differentiation.