widelands-dev team mailing list archive

[GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>]

> I starting looking through the code and there is a lot to digest here. I have a few questions:
> 
> - Why do we require the player command? It seems that we only want to mess with the normal rules of vision through scripting which has to run in parallel on each machine anyways, i.e. should not require a player command. Using a player command will be more fragile, as for example the scripting code has no guarantee when the see/unsee actually happens (can be seconds if the network connection is bad).

I wasn't sure whether we needed one or not and decided to be rather safe
than sorry. I don't have a problem with removing it.



> - The semantis of hidden_fields_ is unclear to me.

Join the club. I arrived at the solution pretty much through trial and
error. Since I wrote this a long time ago, I'd need to completely
reanalzye the code myself - let me know if you need me to do so and I'll
do that next month.

-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1687100-reveal_fields/+merge/323721
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1687100-reveal_fields.