widelands-dev team mailing list archive

[GunChleoc <fios@xxxxxxxxxxxxxxxxxxx>]

Review: Approve

Code LGTM, just 1 tiny nit. Does this still need testing for the seafaring buildings?

Diff comments:

> 
> === modified file 'src/ai/defaultai.cc'
> --- src/ai/defaultai.cc	2017-09-29 16:10:25 +0000
> +++ src/ai/defaultai.cc	2017-10-19 19:37:15 +0000
> @@ -4291,7 +4302,8 @@
>  // dismantle
>  BuildingNecessity DefaultAI::check_building_necessity(BuildingObserver& bo,
>                                                        const PerfEvaluation purpose,
> -                                                      const uint32_t gametime) {
> +                                                      const uint32_t gametime,
> +                                                      const bool seafaring_map) {

Call this seafaring_economy for consistency

>  
>  	bo.primary_priority = 0;
>  


-- 
https://code.launchpad.net/~widelands-dev/widelands/ai_small_requests/+merge/332519
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ai_small_requests.